Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make network.protocol.name conditionally required for messaging #644

Merged

Conversation

pyohannes
Copy link
Contributor

@pyohannes pyohannes commented Jan 18, 2024

Fixes #504

Changes

This makes the usage of network.protocol.name consistent between messaging and HTTP semantic conventions: it is now conditionally required for both metrics and traces if the protocol name isn't obvious for the given messaging system or framework.

This is a breaking change for messaging instrumentations, as a previously recommended attribute is made conditionally required.

Merge requirement checklist

@pyohannes pyohannes requested review from a team January 18, 2024 10:30
@pyohannes pyohannes changed the title Make network.protocol.name conditionally required for messaging Make network.protocol.name conditionally required for messaging Jan 18, 2024
@joaopgrassi joaopgrassi merged commit dd41eac into open-telemetry:main Jan 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Messaging: protocol name requirement level and defaults
4 participants