feat: add os.kernel to os resource semantic conventions #655
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povilasv
force-pushed
the
os.kernel.version
branch
from
3876c3c
to
c7c3fe0
Compare
povilasv
force-pushed
the
os.kernel.version
branch
from
c7c3fe0
to
db0be1d
Compare
|
This contradicts with the same field from ECS - os.kernel According to our guidelines we shouldn't use existing ECS name, in this case |
povilasv
force-pushed
the
os.kernel.version
branch
from
db0be1d
to
2aba006
Compare
povilasv
changed the title
|
@trisch-me thanks for pointing this out, updated PR to os.kernel so that we use the same ECS field |
povilasv
force-pushed
the
os.kernel.version
branch
from
2aba006
to
c7b7fe6
Compare
trisch-me
approved these changes
Jan 23, 2024
mx-psi
requested changes
Jan 24, 2024
There was a problem hiding this comment.
Can we bring this to the Semantic Conventions meeting? I filed #66 some time ago, there are potentially a few other things that one would be interested in related to the kernel (e.g. this is the kernel version, but what about the kernel name?)
I think we need to make a decision regarding if we want to support these and if so how to choose the names so that we use a consistent namespace
|
Thanks for information. makes sense closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #656
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist