trace/http: Add http.{request,response}.size attributes #84
Conversation
|
hi @kamalmarhubi! just a heads up, the HTTP semantic convention WG isn't considering any additions until the HTTP semantic conventions have at least been marked Frozen, so it may be a few weeks until we get to reviewing this proposal |
|
@trask no worries. Should I hold off opening other PRs I might have if they affect one of the changed namespaces? |
|
I think it's fine to continue opening PRs, it's possible that our stale bot might try to close it, but that's ok, just ping to make it not stale, or if it gets closed we can re-open it |
|
@kamalmarhubi Now that early HTTP semconv stability is acheived, I think we can start to entertain this again. Would you be willing to rebase this PR? If not, we may close as stale and you can feel free to re-open a new PR against the current |
|
I'd be happy to try to move this forward. @kamalmarhubi do you plan to rebase this, or should I open a new one? |
|
@gregkalapos I'll rebase and push this tomorrow, sorry for the radio silence |
kamalmarhubi
force-pushed
the
http-request-response-size
branch
from
ff7084b
to
043d590
Compare
|
sorry didn't get this pushed yesterday. I thought it would be a quick rebase but all files had moved around and the tooling had changed. just pushed, including a clarification on over-the-wire vs uncompressed. |
kamalmarhubi
force-pushed
the
http-request-response-size
branch
2 times, most recently
from
926ff07
to
93d3a60
Compare
🤦 |
kamalmarhubi
force-pushed
the
http-request-response-size
branch
from
93d3a60
to
ea7eb51
Compare
kamalmarhubi
force-pushed
the
http-request-response-size
branch
from
ea7eb51
to
b9f28af
Compare
These attributes are the number of bytes in the request or response, including control data, headers, body, and trailers. The names were chosen by taking the [ECS HTTP fields] and replacing `bytes` with `size`, as for `http.request.content.size`. closes open-telemetry#38 [ECS HTTP fields]: https://www.elastic.co/guide/en/ecs/current/ecs-http.html
kamalmarhubi
force-pushed
the
http-request-response-size
branch
from
b9f28af
to
41989e2
Compare
|
just pushed this again with some rewording. |
There was a problem hiding this comment.
Look great, thanks a lot for pushing through and keeping it up to date @kamalmarhubi
I left a couple of naming suggestions, let me know what you think.
…ry#84) Co-authored-by: Liudmila Molkova <[email protected]> Co-authored-by: Alexandra Konrad <[email protected]> Co-authored-by: Joao Grassi <[email protected]>
These attributes are the number of bytes in the request or response, including headers. The names were chosen by taking the ECS HTTP fields and replacing
byteswithsize, as forhttp.request.content.size.closes #38