fix: createRenderRoot lit method denylist

open-wc · Apr 24, 2024 · e60cb14 · e60cb14
1 parent 24fc86b
commit e60cb14
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/packages/analyzer/CHANGELOG.md b/packages/analyzer/CHANGELOG.md
@@ -1,3 +1,6 @@
+## Release 0.9.6
+- Added `createRenderRoot` to lit's method denylist
+
 ## Release 0.9.5
 - When using `litPlugin`, it now removes overriden lit specific lifecycle methods to be aligned with the behavior of overriding lit specific lifecycle methods in classes
 

diff --git a/packages/analyzer/browser/index.js b/packages/analyzer/browser/index.js
@@ -205153,7 +205153,7 @@ var fastPlugin = () => [
 
 // src/features/framework-plugins/lit/method-denylist.js
 function methodDenyListPlugin2() {
-  const METHOD_DENY_LIST = ["requestUpdate", "performUpdate", "shouldUpdate", "update", "render", "firstUpdated", "updated", "willUpdate"];
+  const METHOD_DENY_LIST = ["requestUpdate", "createRenderRoot", "performUpdate", "shouldUpdate", "update", "render", "firstUpdated", "updated", "willUpdate"];
   return {
     name: "CORE - LIT-METHOD-DENYLIST",
     moduleLinkPhase({ moduleDoc }) {

diff --git a/packages/analyzer/package.json b/packages/analyzer/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@custom-elements-manifest/analyzer",
-  "version": "0.9.5",
+  "version": "0.9.6",
   "description": "",
   "license": "MIT",
   "type": "module",

diff --git a/packages/analyzer/src/features/framework-plugins/lit/method-denylist.js b/packages/analyzer/src/features/framework-plugins/lit/method-denylist.js
@@ -4,7 +4,7 @@
  * Excludes methods from the manifest
  */
 export function methodDenyListPlugin() {
-  const METHOD_DENY_LIST = ['requestUpdate', 'performUpdate', 'shouldUpdate', 'update', 'render', 'firstUpdated', 'updated', 'willUpdate'];
+  const METHOD_DENY_LIST = ['requestUpdate', 'createRenderRoot', 'performUpdate', 'shouldUpdate', 'update', 'render', 'firstUpdated', 'updated', 'willUpdate'];
 
   return {
     name: 'CORE - LIT-METHOD-DENYLIST',