Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version of a working open API model generator #180

Open
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

pieterbos
Copy link
Collaborator

@pieterbos pieterbos commented May 13, 2020

Very much draft/experimental OpenAPI model generator. Few problems still:

  • multiple inheritance ONLY takes into account the first ancestor. Needs fixing
  • do we need oneOf references to indicate which subclasses are to be used, or is it ok as is?
  • do we need explicity type property mappings?

TODO:

  • fix the maps in ResourceDescription. It's now excluded from the RM, which is fine, but a reference to a single base file would be even better, so it needs to be correct for the AOM anyway.

@pieterbos pieterbos marked this pull request as draft May 13, 2020 20:17
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #180 (3f570e1) into master (1604340) will increase coverage by 0.48%.
The diff coverage is 85.31%.

@@             Coverage Diff              @@
##             master     #180      +/-   ##
============================================
+ Coverage     70.53%   71.01%   +0.48%     
- Complexity     6489     6693     +204     
============================================
  Files           640      645       +5     
  Lines         21662    22301     +639     
  Branches       3485     3586     +101     
============================================
+ Hits          15279    15838     +559     
- Misses         4755     4798      +43     
- Partials       1628     1665      +37     
Impacted Files Coverage Δ
...java/com/nedap/archie/aom/ArchetypeConstraint.java 100.00% <ø> (ø)
.../main/java/com/nedap/archie/aom/ArchetypeHRID.java 79.48% <ø> (ø)
...main/java/com/nedap/archie/aom/CDefinedObject.java 80.00% <ø> (ø)
...om/src/main/java/com/nedap/archie/aom/CObject.java 81.98% <ø> (ø)
...in/java/com/nedap/archie/aom/CPrimitiveObject.java 66.66% <ø> (ø)
...java/com/nedap/archie/aom/OperationalTemplate.java 80.43% <ø> (ø)
.../com/nedap/archie/aom/ResourceDescriptionItem.java 100.00% <ø> (ø)
...java/com/nedap/archie/aom/primitives/CBoolean.java 34.78% <ø> (ø)
...in/java/com/nedap/archie/aom/primitives/CDate.java 80.00% <ø> (ø)
...ava/com/nedap/archie/aom/primitives/CDateTime.java 80.00% <ø> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1604340...3f570e1. Read the comment docs.

@pieterbos pieterbos marked this pull request as ready for review May 31, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant