TestingFrameworkAdapter: Omit empty error_messages array

Previously, it was language-dependent whether the `error_messages` was shown in case of an error or not. Now, we omit it if no error message is included.
openHPI · Oct 12, 2024 · a0d9e96 · a0d9e96
1 parent d146258
commit a0d9e96
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 9 deletions.
diff --git a/docs/remote_evaluation.yml b/docs/remote_evaluation.yml
@@ -354,7 +354,7 @@ components:
           readOnly: true
         error_messages:
           type: array
-          description: 'If present, the `error_messages` lists test errors extracted by CodeOcean. The array is omitted if no test failed (`failed` = 0) and could be empty if no error was extracted.'
+          description: 'If present, the `error_messages` lists test errors extracted by CodeOcean. The array is omitted if no test failed (`failed` = 0) or if no error was extracted.'
           minItems: 0
           items:
             type: string

diff --git a/lib/julia_adapter.rb b/lib/julia_adapter.rb
@@ -42,13 +42,13 @@ def parse_test_results(output)
     else
       error_matches = output.to_enum(:scan, ASSERTION_ERROR_REGEXP).map { Regexp.last_match } || []
       messages = error_matches.pluck(:message)
-      {count:, failed:, error_messages: messages.flatten.compact_blank}
+      {count:, failed:, error_messages: messages.flatten.compact_blank.presence}
     end
   end
 
   def parse_error(output)
     error_matches = output.to_enum(:scan, LOAD_ERROR_REGEXP).map { Regexp.last_match } || []
     messages = error_matches.pluck(:message)
-    {count: 1, failed: 1, error_messages: messages.flatten.compact_blank}
+    {count: 1, failed: 1, error_messages: messages.flatten.compact_blank.presence}
   end
 end
diff --git a/lib/junit5_adapter.rb b/lib/junit5_adapter.rb
@@ -16,7 +16,7 @@ def parse_output(output)
       {count:, passed: count}
     else
       error_matches = output[:stdout].scan(ASSERTION_ERROR_REGEXP) || []
-      {count:, failed:, error_messages: error_matches.flatten.compact_blank}
+      {count:, failed:, error_messages: error_matches.flatten.compact_blank.presence}
     end
   end
 end
diff --git a/lib/junit_adapter.rb b/lib/junit_adapter.rb
@@ -17,7 +17,7 @@ def parse_output(output)
       count = output[:stdout].scan(COUNT_REGEXP).try(:last).try(:first).try(:to_i) || 0
       failed = output[:stdout].scan(FAILURES_REGEXP).try(:last).try(:first).try(:to_i) || 0
       error_matches = output[:stdout].scan(ASSERTION_ERROR_REGEXP) || []
-      {count:, failed:, error_messages: error_matches.flatten.compact_blank}
+      {count:, failed:, error_messages: error_matches.flatten.compact_blank.presence}
     end
   end
 end
diff --git a/lib/py_lint_adapter.rb b/lib/py_lint_adapter.rb
@@ -43,8 +43,8 @@ def parse_output(output)
     {
       count:,
       failed:,
-      error_messages: concatenated_errors.flatten.compact_blank,
-      detailed_linter_results: assertion_error_matches.flatten.compact_blank,
+      error_messages: concatenated_errors.flatten.compact_blank.presence,
+      detailed_linter_results: assertion_error_matches.flatten.compact_blank.presence,
     }
   end
 

diff --git a/lib/py_unit_adapter.rb b/lib/py_unit_adapter.rb
@@ -32,6 +32,6 @@ def parse_output(output)
       Sentry.capture_message({stderr: output[:stderr], regex: ASSERTION_ERROR_REGEXP}.to_json)
       assertion_error_matches = []
     end
-    {count:, failed: failed + errors, error_messages: assertion_error_matches.flatten.compact_blank}
+    {count:, failed: failed + errors, error_messages: assertion_error_matches.flatten.compact_blank.presence}
   end
 end
diff --git a/lib/r_script_adapter.rb b/lib/r_script_adapter.rb
@@ -14,6 +14,6 @@ def parse_output(output)
     passed = captures.second
     failed = count - passed
     assertion_error_matches = output[:stdout].scan(ASSERTION_ERROR_REGEXP) || []
-    {count:, failed:, error_messages: assertion_error_matches.flatten.compact_blank}
+    {count:, failed:, error_messages: assertion_error_matches.flatten.compact_blank.presence}
   end
 end