Fix overwriting of attributes #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrSerth
approved these changes
Jul 14, 2023
kkoehn
force-pushed
the
fix_missing_attributes
branch
from
9b3128c
to
a30f242
Compare
Codecov Report
@@ Coverage Diff @@
## main #33 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 293 298 +5
=========================================
+ Hits 293 298 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kkoehn
force-pushed
the
fix_missing_attributes
branch
from
a30f242
to
f986c7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a bug where the attributes of a node-group were not converted to json correctly.
The handling of the attributes was in the child-loop.