Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ruby 2.7.6 #865

Merged
merged 27 commits into from
May 12, 2022
Merged

Upgrade to ruby 2.7.6 #865

merged 27 commits into from
May 12, 2022

Conversation

Dome-GER
Copy link
Member

@Dome-GER Dome-GER commented May 11, 2022

Upgrade ruby and remove the therubyracer gem causing libv8 conflicts
on MacOs.

therubyracer is an execjs engine to run JS, e.g. when building
assets. Assets are precompiled locally and copied by the Capistrano
tasks. So asset precompilation can fall back to the installed NodeJS
version.

This also upgrades the rubocop gem to not complain about ruby version
mismatches and drops a seemingly outdated rake task.

dependabot bot and others added 23 commits September 3, 2021 17:41
Bumps [active_enum](https://github.com/adzap/active_enum) from `949849e` to `5cbcf17`.
- [Release notes](https://github.com/adzap/active_enum/releases)
- [Commits](adzap/active_enum@949849e...5cbcf17)

---
updated-dependencies:
- dependency-name: active_enum
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [will_paginate](https://github.com/mislav/will_paginate) from 3.3.0 to 3.3.1.
- [Release notes](https://github.com/mislav/will_paginate/releases)
- [Commits](mislav/will_paginate@v3.3.0...v3.3.1)

---
updated-dependencies:
- dependency-name: will_paginate
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.12.4 to 1.12.5.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.12.4...v1.12.5)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [tinymce-rails](https://github.com/spohlenz/tinymce-rails) from 5.6.2.1 to 5.10.2.
- [Release notes](https://github.com/spohlenz/tinymce-rails/releases)
- [Commits](spohlenz/tinymce-rails@v5.6.2.1...v5.10.2)

---
updated-dependencies:
- dependency-name: tinymce-rails
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [web-console](https://github.com/rails/web-console) from 4.1.0 to 4.2.0.
- [Release notes](https://github.com/rails/web-console/releases)
- [Changelog](https://github.com/rails/web-console/blob/master/CHANGELOG.markdown)
- [Commits](rails/web-console@v4.1.0...v4.2.0)

---
updated-dependencies:
- dependency-name: web-console
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
….2.0

Bump web-console from 4.1.0 to 4.2.0
…-5.10.2

Bump tinymce-rails from 5.6.2.1 to 5.10.2
…cbcf17

Bump active_enum from `949849e` to `5cbcf17`
…nymce-rails-5.10.2

Revert "Bump tinymce-rails from 5.6.2.1 to 5.10.2"
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.12.5 to 1.13.3.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.12.5...v1.13.3)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.3 to 1.13.4.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/v1.13.4/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.13.3...v1.13.4)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Dome-GER Dome-GER changed the title Upgrade to ruby 2.6 Upgrade to ruby 2.7.6 May 11, 2022
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Upgrade ruby and remove the `therubyracer` gem causing libv8 conflicts
on MacOs.

`therubyracer` is an `execjs` engine to run JS, e.g. when building
assets. Assets are precompiled locally and copied by the Capistrano
tasks. So asset precompilation can fall back to the installed NodeJS
version.
This seems to have been used for the SWT lecture but is most likely not
working anymore.
@SanJSp SanJSp changed the base branch from master to staging May 12, 2022 11:15
@SanJSp SanJSp merged commit 0917bd0 into staging May 12, 2022
@SanJSp
Copy link
Contributor

SanJSp commented May 21, 2022

@Dome-GER
While deploying I encountered folliwng issue:

Tasks: TOP => deploy:migrate
(See full trace by running task with --trace)
The deploy has failed with an error: Exception while executing as [email protected]: Exception while executing as [email protected]: rake exit status: 1
rake stdout: Nothing written
rake stderr: rake aborted!
ExecJS::RuntimeUnavailable: Could not find a JavaScript runtime. See https://github.com/rails/execjs for a list of available runtimes.
/var/www/hpi-career/shared/bundle/ruby/2.7.0/gems/execjs-2.7.0/lib/execjs/runtimes.rb:58:in `autodetect'
/var/www/hpi-career/shared/bundle/ruby/2.7.0/gems/execjs-2.7.0/lib/execjs.rb:5:in `<module:ExecJS>'
/var/www/hpi-career/shared/bundle/ruby/2.7.0/gems/execjs-2.7.0/lib/execjs.rb:4:in `<top (required)>'
/var/www/hpi-career/shared/bundle/ruby/2.7.0/gems/activesupport-6.1.4.7/lib/active_support/dependencies.rb:332:in `require'
/var/www/hpi-career/shared/bundle/ruby/2.7.0/gems/activesupport-6.1.4.7/lib/active_support/dependencies.rb:332:in `block in require'
/var/www/hpi-career/shared/bundle/ruby/2.7.0/gems/activesupport-6.1.4.7/lib/active_support/dependencies.rb:299:in `load_dependency'
/var/www/hpi-career/shared/bundle/ruby/2.7.0/gems/activesupport-6.1.4.7/lib/active_support/dependencies.rb:332:in `require'
/var/www/hpi-career/shared/bundle/ruby/2.7.0/gems/uglifier-4.2.0/lib/uglifier.rb:5:in `<top (required)>'
/var/www/hpi-career/releases/20220521131934/config/application.rb:7:in `<top (required)>'
/var/www/hpi-career/releases/20220521131934/Rakefile:4:in `require'
/var/www/hpi-career/releases/20220521131934/Rakefile:4:in `<top (required)>'
/var/www/hpi-career/shared/bundle/ruby/2.7.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
/var/www/hpi-career/shared/bundle/ruby/2.7.0/bin/ruby_executable_hooks:22:in `eval'
/var/www/hpi-career/shared/bundle/ruby/2.7.0/bin/ruby_executable_hooks:22:in `<main>'

Does this mean I simply have to install NodeJs on the staging server as recommended here? Because then we have the problem that I don't have root access to the deployment and staging server :/

@Dome-GER
Copy link
Member Author

Dome-GER commented May 23, 2022

Yes, if NodeJS is installed, this should work. Node can be installed using Capistrano.

@SanJSp
Copy link
Contributor

SanJSp commented Jun 1, 2022

As we do not have access to the JS config we maybe should try to find a solution for this without dropping the JS gem? I would revert this to finally finish the ToS Checkbox by testing it on staging

@Dome-GER
Copy link
Member Author

Dome-GER commented Jun 1, 2022

I can check mini_racer when there is some time.

SanJSp added a commit that referenced this pull request Jun 9, 2022
@SanJSp SanJSp mentioned this pull request Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants