Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Quizzes #235

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Native Quizzes #235

wants to merge 2 commits into from

Conversation

bengelhaupt
Copy link
Contributor

Implementation of native quizzes for self-tests.

In the video there is a wrong time of submission shown. This is an error of the API. The web version has it too.

Fixes #211

@bengelhaupt bengelhaupt added the feature 📦 A new or adjusted user-facing feature. label Apr 9, 2020
@bengelhaupt bengelhaupt self-assigned this Apr 9, 2020
@bengelhaupt bengelhaupt added the schema change ⚠️ Indicates a Realm schema/version change that might conflict with other Pull Requests label Apr 9, 2020
@bengelhaupt
Copy link
Contributor Author

Please test thoroughly and rollout it incrementally because core feature

@@ -0,0 +1,108 @@
package de.xikolo.models

import com.squareup.moshi.Json
Copy link

@github-actions github-actions bot Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Imports must be ordered in lexicographic order without any empty lines in-between

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are sorted and there are no newlines

Copy link
Contributor

@SanJSp SanJSp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey guys, just found this stale review. I'm not working for openHPI anymore, therefore my review is not a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 📦 A new or adjusted user-facing feature. schema change ⚠️ Indicates a Realm schema/version change that might conflict with other Pull Requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native Quizzes
2 participants