-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1559: Added internet connectivity check before loading client info #1560
base: release-1.1
Are you sure you want to change the base?
Fixes #1559: Added internet connectivity check before loading client info #1560
Conversation
...-android/src/main/java/com/mifos/mifosxdroid/online/clientdetails/ClientDetailsFragment.java
Outdated
Show resolved
Hide resolved
103a9b9
to
5ced72c
Compare
...-android/src/main/java/com/mifos/mifosxdroid/online/clientdetails/ClientDetailsFragment.java
Outdated
Show resolved
Hide resolved
...-android/src/main/java/com/mifos/mifosxdroid/online/clientdetails/ClientDetailsFragment.java
Outdated
Show resolved
Hide resolved
282d028
to
8a90109
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b9760b8
to
afcd23a
Compare
afcd23a
to
f4b2be9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @danishjamal104 can you fix the merge conflicts so that we could merge it soon :)
f4b2be9
to
38081eb
Compare
@@ -174,7 +176,15 @@ class ClientDetailsFragment : MifosBaseFragment(), ClientDetailsMvpView { | |||
} | |||
|
|||
fun inflateClientInformation() { | |||
mClientDetailsPresenter!!.loadClientDetailsAndClientAccounts(clientId) | |||
val context = context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danishjamal104 Move this in utils class, If Networkutils exist then fine otherwise create one
Fixes #1559
Screenshot
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xml
style template to your code in Android Studio.Run the unit tests with
./gradlew check
to make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.