Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed dark mode splash screen. #2484

Closed
wants to merge 2 commits into from
Closed

fixed dark mode splash screen. #2484

wants to merge 2 commits into from

Conversation

KUSHAL-RAJ-PAREEK
Copy link

@KUSHAL-RAJ-PAREEK KUSHAL-RAJ-PAREEK commented Jan 15, 2024 •
edited
Loading

@PratyushSingh07
Fixes #2466

WhatsApp.Video.2024-01-12.at.21.33.23_95e115ea.mp4

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@KUSHAL-RAJ-PAREEK
splash screen dark mode fixed
91d2756 
-> so, i added one dark mode colors file in values.
-> now any dark mode related work can be done there.
-> also fixed splash screen dark mode issue.
@KUSHAL-RAJ-PAREEK
fix the dark mode problem of splash screen with using mifos ui libraary.
dfc21eb 
- deleted the old change in values:
 -> deleted the colors(night).

- implemented the theme of splash screen with the base theme.

-so it can work according to mobile theme.
@PratyushSingh07
Copy link
Collaborator

alright @KUSHAL-RAJ-PAREEK 3 things that I would like to point out :

  • Maan sharma was supposed to open the PR first and he had even commented on the issue before you opened this PR yet you decided to go ahead with it
  • you havent followed the contribution guidelines. (Always go through the README.md and CONTRIBUTING.md of any repo before you raise a PR) and lastly
  • have you checked your changes against the light theme ? (i think that splash screen has now been set to always follow dark theme)

I appreciate the enthusiasm, but it's crucial to uphold the essence of open source. Don't limit your contributions solely with GSoC in mind. Take the time to learn from fellow contributors, and, most importantly, avoid rushing the process. I hope you will not repeat this

@KUSHAL-RAJ-PAREEK
Copy link
Author

@PratyushSingh07
but it is working:-

WhatsApp.Video.2024-01-15.at.13.12.06_8bcef29e.mp4

@KUSHAL-RAJ-PAREEK
Copy link
Author

so, if i follow quidelines then i also cant able to make pr?

@KUSHAL-RAJ-PAREEK
Copy link
Author

KUSHAL-RAJ-PAREEK commented Jan 15, 2024 •
edited
Loading

guidelines file for pr in readme is not found.

@PratyushSingh07
Copy link
Collaborator

Why won't you be able to make a PR if you follow the guidelines? You have taken my points out of context.

Also you are changing the system theme. Try changing the theme from inside of the app to see if it works

@PratyushSingh07
Copy link
Collaborator

guidelines file for pr in readme is not found.

Did you try checking contributing.md ??

@KUSHAL-RAJ-PAREEK
Copy link
Author

KUSHAL-RAJ-PAREEK commented Jan 15, 2024 via email

@KUSHAL-RAJ-PAREEK
Copy link
Author

KUSHAL-RAJ-PAREEK commented Jan 15, 2024 via email

@KUSHAL-RAJ-PAREEK
Copy link
Author

ya its not changing let me see.

@PratyushSingh07
Copy link
Collaborator

do you still plan to solve the issue in this PR or should I close it @KUSHAL-RAJ-PAREEK ?

@KUSHAL-RAJ-PAREEK
Copy link
Author

KUSHAL-RAJ-PAREEK commented Jan 16, 2024 •
edited
Loading

@PratyushSingh07 i will spend some more time on this issue.

@PratyushSingh07
Copy link
Collaborator

I am converting this PR to draft

@PratyushSingh07 PratyushSingh07 marked this pull request as draft January 17, 2024 11:35
@PratyushSingh07
Copy link
Collaborator

closing due to inactivity. Reopen the PR if you make any progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: background color of splash screen doesn't change with theme
2 participants
@KUSHAL-RAJ-PAREEK @PratyushSingh07