Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate sensor model behavior tests from integration tests #77

Conversation

ClemensLinnhoff
Copy link
Contributor

@ClemensLinnhoff ClemensLinnhoff commented Mar 20, 2024

Reference to a related issue in the repository
#75

Add a description

  • Add behavior test folder
  • Add CL3 to pipeline
  • Add on-the-fly input trace generation

You can see the separated behavior tests marked with CL3 on the right side of the pipeline.
image

Take this checklist as orientation for yourself, if this PR is ready for Maintainer Review

  • My suggestion follows the governance rules.
  • All commits of this PR are signed.
  • My changes generate no errors when passing CI tests.
  • I updated all documentation (readmes incl. figures) according to my changes.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

@ClemensLinnhoff ClemensLinnhoff linked an issue Mar 20, 2024 that may be closed by this pull request
@ClemensLinnhoff ClemensLinnhoff self-assigned this Mar 20, 2024
@ClemensLinnhoff ClemensLinnhoff marked this pull request as ready for review March 20, 2024 10:33
@ClemensLinnhoff ClemensLinnhoff requested review from a team and jdsika March 20, 2024 10:33
@ClemensLinnhoff ClemensLinnhoff marked this pull request as draft March 20, 2024 17:01
@ClemensLinnhoff
Copy link
Contributor Author

Further behavior tests in this schema added to SL1-3: openMSL/sl-1-3-object-based-generic-perception-object-model#29

@ClemensLinnhoff ClemensLinnhoff marked this pull request as ready for review March 21, 2024 16:09
@jdsika
Copy link

jdsika commented Mar 25, 2024

Readme in folder behavior is missing. Where did we spot the incorrect URL to Persival instead of OpenMSL?

@ClemensLinnhoff
Copy link
Contributor Author

Readme in folder behavior is missing. Where did we spot the incorrect URL to Persival instead of OpenMSL?

I fixed the readme and added a readme for the behavior folder.

The incorred URL is fixed in the documentation PR: openMSL/doc#8

@ClemensLinnhoff ClemensLinnhoff merged commit c1b838b into main Apr 4, 2024
22 checks passed
@ClemensLinnhoff ClemensLinnhoff deleted the 75-separate-sensor-model-behavior-tests-from-integration-tests branch April 4, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Separate sensor model behavior tests from integration tests
3 participants