Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Improve Pip Install #594

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Doc: Improve Pip Install #594

merged 1 commit into from
Nov 12, 2019

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Nov 11, 2019

  • general: update pip first, so we definitely have pip version 19+
  • MPI build: only build itself from source
  • syntax: use pip as python(3) module

- general: update pip first, so we definitely have pip version 19+
- MPI build: only build itself from source
- syntax: use pip as python(3) module
Copy link
Member

@LDAmorim LDAmorim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!
It will help to make sure we always update pip.

pip install openpmd-api
# we need pip 19 or newer
# optional: --user
python3 -m pip install -U pip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually add the python3 -m part of the command to make sure I am installing for the correct python version and I am thinking you did it too. Your change here helps to confirm that we use Python 3.5 - 3.7 as explained in the build dependencies entry of your documentation, which is very nice!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly. As far as I know it's also the recommend way to use pip these days.

python3 -m pip install -U pip

# optional: --user
openPMD_USE_MPI=ON python3 -m pip install openpmd-api --no-binary openpmd-api
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid that, so far this one is not exactly 100% operational with the MPI support in my (frustrating) computer ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take a look! :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we found a work-around for your problem which is unrelated to the instructions herein for now: #593 (comment)

@ax3l ax3l merged commit 65383a2 into openPMD:dev Nov 12, 2019
@ax3l ax3l deleted the doc-improvePipUser branch November 12, 2019 01:24
@ax3l ax3l mentioned this pull request Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants