Fix Python Data_Order #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
bug
affects latest release
api: breaking
ax3l
force-pushed
the
fix-pyDataOrder
branch
from
b29eb6d
to
d90c113
Compare
The `Data_Order` enum in python and thus `Mesh::data_order` are broken due to an upstream bug in pybind11 with non-int enums. Replace the setter and read-only property with a unified property and remove the enum for the sake of simplicity (just compare to a char in popular Python "enums are strings, better spell it right"- manner).
ax3l
force-pushed
the
fix-pyDataOrder
branch
from
d90c113
to
af9161f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Data_Orderenum in python and thusMesh::data_orderare broken due to an upstream bug in pybind11 with non-int enums: pybind/pybind11#1820Replace the setter and read-only property with a unified property and remove the enum for the sake of simplicity (just compare to a char in popular Python "enums are strings, better spell it right"-manner).