Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmlformat incorrectly formats variablelist terms #464

Closed
r0ckarong opened this issue Jul 25, 2018 · 2 comments
Closed

xmlformat incorrectly formats variablelist terms #464

r0ckarong opened this issue Jul 25, 2018 · 2 comments

Comments

@r0ckarong
Copy link

Problem description

When you use xmlformat to correctly format a variablelist the indentation and line breaks for the <term /> contents is done incorrectly and that content comes immediately after the opening tag. This still displays a correct table but is bad for readability.

Expected behavior

The term tags and contents are correctly indented and broken over.

Steps to reproduce the behavior

Format content including variablelist in wrong notation with xmlformat.

Initial content:

<variablelist>
<varlistentry><term><literal>Image</literal></term><listitem><para>Select the image your machines will be created from</para></listitem></varlistentry>
</variablelist>

After xmlformat:

         <varlistentry>
          <term><literal>Image</literal> # This should be in the next line
          </term>
          <listitem>
           <para>
            Select the image your machines will be created from
           </para>
          </listitem>
         </varlistentry>
       </variablelist>

Manually fixed content:

       <variablelist>
         <varlistentry>
          <term>
           <literal>Image</literal> #This is now formatted correctly
          </term>
          <listitem>
           <para>
            Select the image your machines will be created from
           </para>
          </listitem>
         </varlistentry>
       </variablelist>
ghost pushed a commit that referenced this issue Jul 25, 2018
@ghost
Copy link

ghost commented Jul 25, 2018

Mh... Imo, <term/>s should be formatted like titles, so what is incorrect in your example is only the line break just before the closing </term>. I've opened PR #465.

ghost pushed a commit that referenced this issue Jul 25, 2018
@fsundermeyer
Copy link
Member

Fixed with fff76bc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants