dllexport solv_version as well #379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok we need to actually install the Would you be OK to move the file to the solv directory as |
wolfv
force-pushed
the
win_export_solv_version
branch
from
d84f014
to
a5b7e68
Compare
wolfv
force-pushed
the
win_export_solv_version
branch
from
a5b7e68
to
d67a1de
Compare
|
@mlschroe are there any objections to this PR? |
Conan-Kudo
approved these changes
Aug 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I didn't see this the first time around.
I saw that you have a
.verfile with all exported symbols but quickly googling didn't tell me if we could use this on Windows as well.