Make reading from Pool more thread-safe #472
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't fix the problem completely, but mitigates it so the pool can be accessed from tens of concurrent threads.
Conan-Kudo
approved these changes
Aug 17, 2021
|
It looks like that the patch will not help much. First of all it does not solve the issue but it makes it less frequent. According to #471 (comment) there are other problems in libsolv related to multi-thread safety. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't fix the problem completely, but mitigates it
so the pool can be accessed from tens of concurrent threads.
I tested pool_tmpjoin() and the performance is 40% worse (locking has a cost).
We need to test it in real-life scenarios, the overall impact should not be that bad.
evrpernashows 5% performance hit, which is quite reasonableTries to fix #471