-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically wrap lines created by changesgenerate and default to name and email #461
Open
luc14n0
wants to merge
2
commits into
openSUSE:master
Choose a base branch
from
luc14n0:changesgenerate-wrap-lines
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 13, 2023
luc14n0
force-pushed
the
changesgenerate-wrap-lines
branch
from
February 14, 2023 08:48
7448784
to
8714802
Compare
houndci-bot
reviewed
Feb 14, 2023
luc14n0
force-pushed
the
changesgenerate-wrap-lines
branch
from
February 18, 2023 04:57
8714802
to
4e1b229
Compare
Add automatic line wrapping feature for lines generated by changesgenerate that are longer than 67 characters, aligning with openSUSE's current guidelines. https://en.opensuse.org/openSUSE:Creating_a_changes_file_(RPM) Signed-off-by: Luciano Santos <[email protected]>
luc14n0
force-pushed
the
changesgenerate-wrap-lines
branch
from
April 14, 2023 05:55
4e1b229
to
adec49d
Compare
houndci-bot
reviewed
Apr 14, 2023
Modify default behavior of changesgenerate to add packager's name AND email by default, instead of only the former, in the generated changes entry header. This also adds changesemail, a new parameter for _service files, that must be used along with changesauthor whenever configuring them manually is needed. Signed-off-by: Luciano Santos <[email protected]>
luc14n0
force-pushed
the
changesgenerate-wrap-lines
branch
from
April 14, 2023 06:10
adec49d
to
b8719ab
Compare
luc14n0
changed the title
Automatically wrap lines created by changesgenerate and default to name/email for changesauthor
Automatically wrap lines created by changesgenerate and default to name and email
Apr 14, 2023
There's only one issue with one of my last iterations. When using the service in the CLI fails:
I don't know why the commit messages aren't being written to the temporary |
Ping! |
Another ping! |
In #502 I implemented the real name handling differently, like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should bring us closer to how
osc vc
behaves:BEFORE:
AFTER:
The module in use here is
textwrap
and it's part of Python's Standard Library, so there's no need for extra dependencies. And unless there's a word longer than 67 characters or a hyphened compound word, words shouldn't get split.The modifications I did to
SystemExit()
should look like this, for thechangesauthor
:And for the newly introduced
changesemail
parameter: