Create changes file if none exists #484
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 28, 2024
JanZerebecki
force-pushed
the
create-changes
branch
from
1620e74
to
1d47166
Compare
JanZerebecki
force-pushed
the
create-changes
branch
from
1d47166
to
27cc964
Compare
This was noticed in a CI generated package with only a _service file, which now fails because I made rpm error when it finds no changes file in Factory. Fixes: https://bugzilla.suse.com/show_bug.cgi?id=1220540
JanZerebecki
force-pushed
the
create-changes
branch
from
27cc964
to
b0033d0
Compare
|
Tested manually to work for both cases of existing an non-existing changes file. CI failure unrelated. |
bmwiedemann
approved these changes
Mar 19, 2024
|
erm, you always create a changes file now even not wanted? That won't solve failures where you don't have a changes file on purpose, but build against factory (without any _service). |
|
@adrianschroeter This only creates the changes file if it is requested via the option for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was noticed in a CI generated package with only a _service file, which now fails because I made rpm error when it finds no changes file in Factory.
Fixes: https://bugzilla.suse.com/show_bug.cgi?id=1220540