Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore the stderr output when getting the parent tag #492

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaimeMF
Copy link

@jaimeMF jaimeMF commented May 30, 2024

On https://github.com/organicmaps/organicmaps a warning is printed and it produces and invalid tag name

TarSCM/helpers.py Outdated Show resolved Hide resolved
TarSCM/helpers.py Outdated Show resolved Hide resolved
TarSCM/scm/git.py Outdated Show resolved Hide resolved
@jaimeMF jaimeMF force-pushed the ignore_stderr_for_parent_tag branch from 8977a28 to 89bd1c7 Compare May 30, 2024 20:54
@jaimeMF jaimeMF force-pushed the ignore_stderr_for_parent_tag branch from 89bd1c7 to 8722047 Compare May 30, 2024 20:55
@adrianschroeter
Copy link
Member

adrianschroeter commented Jul 31, 2024

hm, not being a fan ... it would make debugging way harder in other cases.
What is the root cause of that error output?

@jaimeMF
Copy link
Author

jaimeMF commented Jul 31, 2024

hm, not being a fan ... it would make debugging way harder in other cases. What is the root cause of that error output?

With the repository from https://github.com/organicmaps/organicmaps if I checkout the tag 2024.05.11-3-android and run the command used by the obs service I get:

>> git describe --tags --abbrev=0
warning: tag '2024.05.11-3-android' is externally known as '2024.05.11-3-android-rc'
2024.05.11-3-android-rc-0-gd8a071a02319e1d724ae6677c148c57fdb159337

So it is just a warning, but since it is included with the tag it produces and error later on.

With the last tag on the OrganicMaps repository it doesn't happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants