Avoid messing up tags with dashes #84
Conversation
|
I can sympathise with the intention behind the change, but this seems to cause valid test failures, e.g. so I suspect it needs a slightly more sophisticated approach than just removing this conversion. |
|
Here is an update. Not sure why travis fails, I can't make sense of what E302 is supposed to be. |
|
On 2015-10-09 07:28:38 -0700, jengelh wrote:
|
When @PARENT_TAG@ is something like "7.2.1-rc2", then using versionformat="@[email protected]@TAG_OFFSET@" would cause "7.2.1rc2.g123" rather than "7.2.1-rc2.g123" to be emitted, which is undesired. The function version_iso_cleanup is in the way. This function is supposed to transform the output of %ad/%cd into %Y%m%d. However, version_iso_cleanup modifies the entire string rather than just the portion belonging to %ad, causing the above problem. Therefore, we mark the %ad portion, by changing %ad to something like "<ad<%ad>>" before feeding it to git-log. This yields "<ad<Fri Oct 9 ...>>", which can be found more exactly by a regex. I choose '<' and '>' as metacharacters because those cannot appear in a rpm version number. Secondly, "Fri Oct 9" looks inherently locale-specific, providing another problem point. It is safer to internally rewrite %ad to %at.
|
It seems there are still |
|
@jengelh Is this still relevant or could we just close the issue? |
|
Issues don't magically disappear, so yeah, still relevant. |
|
Should be resolved with #390 |
When @PARENT_TAG@ is something like "foo-7.2.1-rc2", then using
versionformat="@[email protected]@TAG_OFFSET@" would cause
"foo7.2.1rc2.g123" to be emitted, which is — from my side — totally undesired.