Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'meta' command capable of editing attributes #1360

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

dmach
Copy link
Contributor

@dmach dmach commented Jul 18, 2023

Fixes: #435

@dmach
Copy link
Contributor Author

dmach commented Jul 18, 2023

Related to openSUSE/open-build-service#13938 - it may allow us dropping the new code doing POST request instead of PUT

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 21.03% and project coverage change: +0.24% 🎉

Comparison is base (3559336) 28.98% compared to head (95998ef) 29.22%.
Report is 37 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1360      +/-   ##
==========================================
+ Coverage   28.98%   29.22%   +0.24%     
==========================================
  Files          36       47      +11     
  Lines       16729    17238     +509     
==========================================
+ Hits         4849     5038     +189     
- Misses      11880    12200     +320     
Files Changed Coverage Δ
osc/_private/project.py 0.00% <0.00%> (ø)
osc/commandline.py 19.08% <0.00%> (+0.06%) ⬆️
osc/commands/repo.py 0.00% <0.00%> (ø)
osc/commands/repo_add.py 0.00% <0.00%> (ø)
osc/commands/repo_list.py 0.00% <0.00%> (ø)
osc/commands/repo_remove.py 0.00% <0.00%> (ø)
osc/_private/api.py 46.66% <8.00%> (-14.88%) ⬇️
osc/core.py 35.30% <11.11%> (-0.35%) ⬇️
osc/output/tty.py 46.66% <46.66%> (ø)
osc/output/key_value_table.py 86.79% <86.79%> (ø)
... and 3 more

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

osc/commandline.py Fixed Show fixed Hide fixed
osc/commandline.py Fixed Show fixed Hide fixed
@dmach dmach merged commit b36c210 into openSUSE:master Aug 7, 2023
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

osc meta attribute openSUSE:Factory -a ATTR -e -> no edit option
1 participant