Change osc.build module to use 'store' object instead of calling core.store_*() functions #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1369 +/- ##
=======================================
Coverage 28.85% 28.86%
=======================================
Files 45 45
Lines 17070 17065 -5
=======================================
Hits 4925 4925
+ Misses 12145 12140 -5
☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -639,7 +640,7 @@ | |||
| return run_external(cmd[0], *cmd[1:]) | |||
|
|
|||
|
|
|||
| def main(apiurl, opts, argv): | |||
| def main(apiurl, store, opts, argv): | |||
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
….store_*() functions Also drop the "This may be a project managed entirely via git?" section because it was never triggered due to a bug: >>> project = store_read_project(Path.cwd()) should have been >>> project = store_read_project(Path.cwd().parent) Let's bring it back when a proper git scm support is in place.
dmach
force-pushed
the
build-store-object
branch
from
32ea3b2
to
a9af18d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also drop the "This may be a project managed entirely via git?" section because it was never triggered due to a bug:
should have been
Let's bring it back when a proper git scm support is in place.