-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'gitea_api' module and 'git-obs' executable #1599
Conversation
Hello @dmach! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-10-11 11:13:56 UTC |
@dcermak could you review the code and check if it works for you? |
from .connection import GiteaHTTPResponse | ||
|
||
|
||
class GiteaException(oscerr.OscBaseError): |
Check failure
Code scanning / CodeQL
Missing call to `__init__` during object initialization Error
method OscBaseError.__init__
__init__ method
df3d828
to
e5e3bba
Compare
Is this mostly a re-implementation of gitea-tea to interact with a gitea instance? |
The basic functionality is going to be similar. IIUC @AdamMajer is working on a staging tooling that overlaps with this tool. We'll need to decide if we need both. |
Interactive reviews should use "Issue comments" and "Pull Request Reviews" API to read and leave comments on a PR. My ideal state is to use GPG signatures for approvals and not rely on Gitea as a secure record of this data. But we'll still need a tool to do actual review (ie. diffs) and communication. |
a9b0b16
to
9aa3fad
Compare
Co-authored-by: Dan Čermák <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed in the sync meeting, the extra binary should be called "git-obs" to have it callable via "git obs"
@@ -35,6 +35,7 @@ | |||
from . import oscerr | |||
from . import output | |||
from . import store as osc_store | |||
from .commandline_common import * |
Check notice
Code scanning / CodeQL
'import *' may pollute namespace Note
osc.commandline_common
…several seconds to container startup
…e git-obs available as a git sub-command
TODO
login list
login add
--set-as-default
login remove
login update
--set-as-default
ssh-key list
ssh-key add
ssh-key remove
clone
--directory
option with an optional argument to get closer to thegit clone
command?repo
commandfork
repo
commandgit obs
subcommand