Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker Compose file format: 2.0 → 2.4 (minor) #2663

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

AndrewKvalheim
Copy link
Member

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the upstream master branch.
  • The tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves

In my local development environment I'd like to limit resource usage, by setting in docker-compose.override.yml e.g.:

services:
  osem:
    cpus: 2
    mem_limit: 2gb

The cpus parameter requires Compose file version ~> 2.2, but the provided files are currently using 2.0.

Changes proposed in this pull request

Update to the latest version 2 format.

AndrewKvalheim added a commit to AndrewKvalheim/osem that referenced this pull request May 31, 2020
AndrewKvalheim added a commit to AndrewKvalheim/osem that referenced this pull request May 31, 2020
Allows the use of additional parameters such as `cpus` and
`healthcheck`.
@hennevogel hennevogel merged commit 32164c4 into openSUSE:master Mar 6, 2021
@AndrewKvalheim AndrewKvalheim deleted the docker-compose-v2.4 branch June 13, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants