Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker setup for newer or updated image builds #2680

Closed
wants to merge 2 commits into from

Conversation

chocoelho
Copy link
Contributor

@chocoelho chocoelho commented Jul 10, 2020

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the upstream master branch.
  • The tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works(if appropriate).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves/which issues does this fix?:

Changes proposed in this pull request:

  • Add OSEM_RUBY_VERSION as build argument to Docker setup

@AndrewKvalheim
Copy link
Member

Curious to hear your thoughts on this vs. #2646, which look like two different attempts at solving the same problem.

@chocoelho
Copy link
Contributor Author

Curious to hear your thoughts on this vs. #2646, which look like two different attempts at solving the same problem.

I just wanted to kept the existent approach as using OSEM_RUBY_VERSION. This change would make it possible to configure this variable at build time.

@AndrewKvalheim AndrewKvalheim mentioned this pull request Nov 11, 2020
1 task
@hennevogel
Copy link
Member

The variable really is only valuable if you want to use another ruby version. The docker build failed because the underlying OS changed.

@hennevogel hennevogel closed this Mar 6, 2021
AndrewKvalheim added a commit to AndrewKvalheim/osem that referenced this pull request Jun 13, 2021
Targets:

    docker run --rm \
        registry.opensuse.org/opensuse/infrastructure/osem/containers/osem/base \
        ruby --version

See also:

  - openSUSE#2646
  - openSUSE#2680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants