Order rooms by name in the schedule #2913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hennevogel
requested changes
Jan 31, 2022
spec/features/schedules_spec.rb
Outdated
| let!(:conference) { create(:conference) } | ||
| let!(:venue) { create(:venue, conference: conference) } | ||
|
|
||
| describe 'with unalphabetized rooms' do |
There was a problem hiding this comment.
I don't think we need a spec for .order. The ActiveRecord test suite will make sure that this will never break...
CI time is developer time.
Adapted from SeaGL@bf3be56
|
Makes sense, thanks. |
AndrewKvalheim
force-pushed
the
schedule-alphabetize-rooms
branch
from
6a2985f
to
3da0bb3
Compare
hennevogel
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterbranch.Short description of what this resolves
On the published schedule, rooms are listed in undefined order—in practice, usually the order of creation. This can make the schedule confusing to read.
Changes proposed in this pull request
An explicit ordering feature would be useful, but for now it’s an improvement to just order by name.