Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API request: setting description of transaction with libtukit #55

Closed
Conan-Kudo opened this issue Feb 17, 2021 · 4 comments
Closed

API request: setting description of transaction with libtukit #55

Conan-Kudo opened this issue Feb 17, 2021 · 4 comments

Comments

@Conan-Kudo
Copy link
Member

Something I've noticed is that I don't seem to have a way to set descriptions for transactions. It'd be nice if there was a way to be able to set a description for a snapshot so that I can put the command or action into the description through the txnupd plugin.
@laenion
Copy link
Collaborator

laenion commented Feb 17, 2021

Thanks for the feedback! I'm currently working on exposing / integrating more direct snapshot handling functionality for the dbus interface. I'll make sure setting the description will be part of it!

@laenion
Copy link
Collaborator

laenion commented Jul 5, 2022

I assume the snapshot description should be set when the snapshot is created.

This leads to two options:

  1. Add an additional (optional) parameter to the lib/Transaction.hpp init method. For 4.0 release the ABI is changing anyway, so that may be an option.
  2. Add a method setSnapshotDescription to the Transaction class.

Any preference?

@Conan-Kudo
Copy link
Member Author

Either should be fine with me.

laenion added a commit that referenced this issue Jul 13, 2022
@laenion
Allow customizing description of new snapshot
2a2117d 
Implements [gh##55].
@laenion
Copy link
Collaborator

laenion commented Jul 14, 2022

Implemented as an optional parameter now, and also reworked the D-Bus interface to support it.

@laenion laenion closed this as completed Jul 14, 2022
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this issue Aug 9, 2022
@bmwiedemann
Update transactional-update to version 4.0.0 / rev 89 via SR 993808
3c34455 
https://build.opensuse.org/request/show/993808
by user fos + dimstar_suse
- Version 4.0.0 (final)
  - Changed "List" method of Snapshot D-Bus interface to return a map of properties instead of a comma separated list of strings; this will allow retrieving the snapshot properties even if they contain a comma in their value [boo#1202147]
  - Remove "Snapshot.hpp" as a public API for now - all public functionality is part of SnapshotManager.hpp
  - Add header file documentation for SnapshotManager.hpp
  - Add method to delete snapshot [gh#openSUSE/transactional-update#52]
  - Allow setting description of snapshot [gh#openSUSE/transactional-update#55]
  - create_dirs_from_rpmdb: set SELinux file context of missing directories [gh#openSUSE/transactional-update#84], [bsc#1197242]
  - Fix broken logrotate due to typo in config file [gh#openSUSE/transactional-update#87]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Conan-Kudo @laenion