create_dirs_from_rpmdb: set SELinux file context of missing directories #86
Conversation
Styled with: BasedOnStyle: Google, IndentWidth: 4, ColumnLimit: 0
An error state could be lost, if the creation of a successor directory was successful. The previous error state has been overwritten.
During a t-u package installation, the SELinux RPM plugin handles the contexts of created elements. The /var directory could be located on a separate partition, which is not mounted in the tu-env. Therefore the file contexts are lost in the snapshot and need to be set after boot by the create_dirs_from_rpmdb service. Fixes openSUSE#84
|
Thanks a lot for the SELinux fixes and return code changes! The approach to delete the directories sounds reasonable; let's see if it works out that way, it can still be changed if proves to be troublesome. Code review and tests are looking good, so I'll accept the coding style "fixes", too, although at least one person won't be happy about them :-) The only thing missing from this pull request are the Makefile.am changes for linking SELinux, I'll add them in a minute. (And probably also some debugging output when the corresponding flag is set.) |
|
Thanks for merging! Looking forward to remove our workaround due to this bug. Regarding the styling: I'm sorry. I didn't want to offend anyone and just followed the style of the other files :) About the Makefile: Damn... I forget to readd it again after changing the work mode from best effort to directory deletion... Force push is not always good ;) Thanks anyway for adding it! |
During a t-u package installation, the SELinux RPM plugin handles the
contexts of created elements. The
/vardirectory could be located on aseparate partition, which is not mounted in the tu-env. Therefore the
file contexts are lost in the snapshot and need to be set after boot by
the
create_dirs_from_rpmdbservice.Fixes #84
Furthermore the coding style of
create_dirs_from_rpmdbwas fixed anda small issue about handling the return code of
create_dirs()was fixed, too.