-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/notify method #93
Conversation
Signed-off-by: Luca Di Maio <[email protected]>
Signed-off-by: Luca Di Maio <[email protected]>
Signed-off-by: Luca Di Maio <[email protected]>
Signed-off-by: Luca Di Maio <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes yes a thousand times yes :)
Thanks :) This will require on MicroOS Desktop a specific settings for the reboot method (set to notify) |
Sorry for the delay, I'm currently on vacation. Will have a look at it on Tuesday when I'm back, but I can say already that I like the general idea a lot! |
Released transactional-update 4.1.0 with this PR included and submitted to Factory: https://build.opensuse.org/request/show/1031369 Thanks a lot for your work, I'm really looking forward to use it! |
Thanks a lot for merging! |
https://build.opensuse.org/request/show/1031369 by user fos + dimstar_suse - Version 4.1.0 - t-u: Add a "setup-kdump" command; implements [jsc#PED-1441] - Export TRANSACTIONAL_UPDATE_ROOT (the path to the snapshot) in the update environment; implements [jsc#PED-1078] - Add support for "notify" reboot method for desktop use [gh#openSUSE/transactional-update#93] - Fix kdump initrd recreation detection; the check was performed in the active snapshot instead of the target snapshot - Document register command [bsc#1202900] - Avoid unnecessary snapshots for register command [bsc#1202901] - Various optimizations for register command - Remove bogus error message when triggering reboot - Rework /etc overlay documentation in "The Transactional Update Guide" - Fix incorrect manpage formatting - Remove leftover "salt" reboot method in configuration examp
Hi all,
As discussed in the mailing list here: https://lists.opensuse.org/archives/list/[email protected]/thread/E6ZYOXFKRM5BODY25PEWZRBCMEFYS66W/
This pull request aims to add a notify method (
reboot_via_notify
) so that on MicroOS Desktop setups we can let the user know that the t-u timer applied updates successfully.This should be a more suitable way to apply updates automatically on desktop setups where 3:30am reboots are not advisable.
This PR also adds
Persistent=true
to the systemd-timer, in order to ensure that updates are performed if the machine is in sleep/shutdown during the timer window.This PR goes in hand with this other tool: https://github.com/89luca89/transactional-update-notifier
Which is the client/server app that is called by the
reboot_via_notify
method, in order to sent notifications to all logged user graphically.To summarize this PR implements:
reboot_via_notify
method in the t-u scriptReboot.cpp
Also the notifier tool supports reporting faliures, we can evaluate if using this feature or not in the t-u script
Signed-off-by: Luca Di Maio [email protected]