Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add IFU CI support #204

Merged
merged 17 commits into from
Aug 2, 2023
Merged

feat: Add IFU CI support #204

merged 17 commits into from
Aug 2, 2023

Conversation

nickevansuk
Copy link
Contributor

@nickevansuk nickevansuk commented Aug 2, 2023

This PR adds IndividualFacilityUse functionality to the OpenActive Reference Implementation. IFUs have been the recommended approach to publishing facilities data for a while, so it is useful to have the ref impl aligned with this.


In order to fully finish off this PR the following needs to happen (apart from the review comments below):

  • 1. an appsettings.ifu.json file needs to be added to this PR (or based on the comment below re default FU vs IFU behaviour, an appsettings.fuNoIfu.json)
  • 2. In Test Suite, an env file needs to be added to run Test Suite in IFU mode
  • 3. This branch needs to be renamed to be coverage/ifus so that the Test Suite branch in 2 run tests against this branch
  • 4. Add individual facility uses to the Github Actions test matrix so that every CI run also runs IFU tests

@nickevansuk nickevansuk changed the base branch from master to feature/ifus August 2, 2023 11:59
@nickevansuk nickevansuk changed the base branch from feature/ifus to master August 2, 2023 12:08
@nickevansuk nickevansuk merged commit d643a02 into master Aug 2, 2023
20 of 21 checks passed
@nickevansuk nickevansuk deleted the coverage/ifus branch August 2, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants