data-quality: schedule: Catch errors when the model or subclassgraph …

…is unknown
openactive · Apr 1, 2021 · 95c782f · 95c782f
1 parent 4bb1e75
commit 95c782f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/rules/data-quality/scheduleeventype-is-valid-event-subclass-rule-spec.js b/src/rules/data-quality/scheduleeventype-is-valid-event-subclass-rule-spec.js
@@ -91,7 +91,7 @@ describe('ScheduleEventTypeIsEventSubclass', () => {
     }
   });
 
-  it('should return errors if scheduleEventType does not have a subClassGraph', async () => {
+  it('should not errors if scheduleEventType does not have a subClassGraph', async () => {
     const model = new Model({
       type: 'Schedule',
       subClassGraph: ['#Event'],

diff --git a/src/rules/data-quality/scheduleeventype-is-valid-event-subclass-rule.js b/src/rules/data-quality/scheduleeventype-is-valid-event-subclass-rule.js
@@ -63,7 +63,7 @@ module.exports = class ScheduleEventTypeIsEventSubclass extends Rule {
       errorCondition = 'modelIsNotEventSubClass';
     }
 
-    if (errorCondition === 'modelIsNotEventSubClass') {
+    if (errorCondition) {
       errors.push(
         this.createError(
           errorCondition,
@@ -73,8 +73,6 @@ module.exports = class ScheduleEventTypeIsEventSubclass extends Rule {
           },
         ),
       );
-    } else {
-      return [];
     }
 
     return errors;