Fix #9. compatibility for tostring and tobytes

[carpedm20]

No description provided.

[gdb]

Can we do this without catching the exception? It'd be nicer to know in advance which method we should use, and then just make one attempt. Otherwise we risk catching an unintended error.

[carpedm20]

@gdb How about checking the version of numpy? Because tobytes was added after 1.9.0 and it will cause error for numpy<=1.8.2.

[gdb]

Sounds great!

On Thursday, April 28, 2016, Taehoon Kim [email protected] wrote:

@gdb https://github.com/gdb How about checking the version of numpy?
Because tobytes was added after 1.9.0 and it will cause error for
numpy<=1.8.2.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10 (comment)

Sent from mobile

[gdb]

Think we need to do something more sophisticated here:

>>> '1.10.0' >= '1.9.0'
False

Try using Disutils version parsing, like we do here: https://github.com/openai/mujoco-py/blob/master/mujoco_py/config.py#L45?

[matheusportela]

This should do the work:

distutils.version.StrictVersion(numpy.__version__) >= distutils.version.StrictVersion('1.9.0')

[carpedm20]

@gdb: Now the version check is done as:

if distutils.version.StrictVersion(np.__version__) >= distutils.version.StrictVersion('1.9.0'):
    self.proc.stdin.write(frame.tobytes())
else:
    self.proc.stdin.write(frame.tostring())

[gdb]

Thank you!