Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Parse Completion with raw response output #1056

Closed
wants to merge 1 commit into from
Closed

Implement Parse Completion with raw response output #1056

wants to merge 1 commit into from

Conversation

margostino
Copy link

@margostino margostino commented Sep 11, 2024 •
edited
Loading

  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

Support withResponse() when parse completion is used. This PR is ONLY to make the point of my feature request. It would need another implementation more aligned with chat completion.

Additional context & links

@margostino margostino requested a review from a team as a code owner September 11, 2024 09:10
@RobertCraigie
Copy link
Collaborator

Thanks for the PR! I think there's a better way we can go about this though so I've opened #1058

@margostino margostino mentioned this pull request Sep 11, 2024
Closed
1 task
@margostino
Copy link
Author

Thanks for the PR! I think there's a better way we can go about this though so I've opened #1058

Thanks for the PR! I think there's a better way we can go about this though so I've opened #1058

Agree. Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@margostino @RobertCraigie