-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shell auto-completion #1603
base: main
Are you sure you want to change the base?
Changes from 37 commits
bf189a9
01d72f3
f75f8a5
30f8013
5a7d06e
f95433c
080a818
f724c8b
f734f73
38dc4ad
0e74b73
9bd76a1
9ba029d
11f3670
5a65355
9742678
f3d9071
1ce382c
cbb5052
f02e7ea
016be6e
0566711
bdd7b7b
3c22cda
faa5dd6
e112898
177fbea
4430b99
1c75144
6a41a59
5e8ec65
9b097bb
37d90ba
995a13d
3701916
51d8d52
4adbc2d
361f10d
984a02e
8e70ec3
889c3b9
8ef585d
ca2bd27
77c2841
6d2e5fa
5eda534
6041733
f333c28
8e8acfc
a78746d
b0d6047
2f6b763
f7bc7ae
9ab6959
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,7 @@ dependencies = [ | |
"cached-property; python_version < '3.8'", | ||
"tqdm > 4", | ||
"jiter>=0.4.0, <1", | ||
"argcomplete >= 1.12.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd like to avoid adding a new required dependency, can we add this as an optional dependency? I'm thinking something like this, thoughts?
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for the feedback! Our team discussed this and wanted to share our approach to add argcomplete as an optional dependency. To avoid making argcomplete a required dependency, we plan to:
Please let us know if there are any additional changes we should consider. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That sounds good to me! I don't think there's any other changes needed. For what it's worth I don't think we need the complexity of a proxy here though as the dependency is only ever used in one place anyway we can just change that call site to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have included the changes for making |
||
] | ||
requires-python = ">= 3.7.1" | ||
classifiers = [ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: are there existing docs we could link to here instead of listing out all the possible environments here? maybe argcomplete's docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both temporary and permanent argcomplete activation instructions for Fish and Powershell are available on argcomplete's contrib directory. However, only the temporary activation commands for Bash and Zsh are listed on argcomplete's README file. The commands to activate autocompletion permanently for Bash and Zsh are not found anywhere on argcomplete's docs.
What are your opinions on replacing all the other environment activation instructions with the appropriate links to argcomplete's docs, while keeping these lines for permanent activation on Bash and Zsh?
For Bash:
For Zsh: