Make the trailing / optional at openai.base_url setting #780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
Use
self._base_url
to replaceself.base_url
in BaseClient class's_prepare_url
method.Additional context & links
It does not hurt OpenAI class client, because
self.base_url
is referred toself._base_url
base on this lineBut this change would help the module_client cases, when we are setting
openai.base_url="an_endpoint_url_WITHOUT_training_/_at_the_end"
Due to this line, the
base_url
would directly return the URL WITHOUT trailing/
and fail the requstThe workaround is always add training
/
at the end of the module client base_url, but with this PR fix, this step is optional (_base_url is/
padded already here)