Relax triton requirements for compatibility with pytorch 2.1 and newer #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jongwook, what is the schedule for the next PyPI release? |
yaomingamd
pushed a commit
to ROCm/whisper
that referenced
this pull request
Nov 27, 2023
xingjianan
added a commit
to xingjianan/whisper
that referenced
this pull request
Aug 19, 2024
Similar to openai#1802, but now when pytorch upgrades to 2.4, it requires triton==3.0.0. I am not sure if it makes sense to remove the upper bound version constraints
miracle1015
reviewed
Sep 9, 2024
| @@ -13,7 +13,7 @@ def read_version(fname="whisper/version.py"): | |||
|
|
|||
| requirements = [] | |||
| if sys.platform.startswith("linux") and platform.machine() == "x86_64": | |||
| requirements.append("triton==2.0.0") | |||
There was a problem hiding this comment.
- requirement.append("triton>=2.0.0,<3")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyPI package of PyTorch 2.1 uses triton==2.1.0, which makes it incompatible with whisper due to overly strict requirement triton==2.0.0.