Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable handling IBI data as heart rate data in openambit2gpx #211

Closed
wants to merge 2 commits into from

Conversation

vascotenner
Copy link
Contributor

Solves #181: openambit2gpx can now handle IBI data as heart rate data

And has already merge PR #209: python 3 support

@vascotenner vascotenner mentioned this pull request Dec 29, 2018
@centic9 centic9 changed the title openambit2gpx can now handle IBI data as heart rate data Enable handling IBI data as heart rate data in openambit2gpx Oct 16, 2019
@vascotenner
Copy link
Contributor Author

Is there any interest in merging this to master?

@centic9
Copy link
Contributor

centic9 commented Feb 14, 2021

Do you do the IBI->HR conversion because the HR-Data is missing otherwise or do you think the IBI value is "better"?

If the former, I would probably try to use "HR" whenever it is available and fall back to IBI only when "HR" is missing to not cause a change compared to all previously generated GPX files.

In a quick test it seems generated HR values are slightly different for large parts of the resulting GPX-files, not just some small time-shift.

@vascotenner
Copy link
Contributor Author

vascotenner commented Feb 15, 2021 via email

@centic9
Copy link
Contributor

centic9 commented Feb 17, 2021

Ok, so it seems to be depending on the device if the HR samples are available or not.

Maybe we can check for the Device in the tag DeviceInfo and choose "HR" or "IBI" based on this to not change produced files for the Devices that properly have HR included already.

@vascotenner
Copy link
Contributor Author

vascotenner commented Feb 18, 2021 via email

@marguslt
Copy link

@centic9 ,

Ok, so it seems to be depending on the device if the HR samples are available or not.

Maybe we can check for the Device in the tag DeviceInfo and choose "HR" or "IBI" based on this to not change produced files for the Devices that properly have HR included already.

Not just the watch, it's also depending on used heart rate monitor, at least for Ambit3 - #181 (comment) and following comments, until Mio Link.

Suunto Smart ANT belts and Smart Sensor (Bluetooth , for Ambit3 range ) are always sending out IBI values. As far as I know, it's the same for most other ANT+ & Bluetooth chest HRMs as well, at least those by Polar & Garmin.
While optical HRMs (Mio Link, Scosche Rhythm, Polar OH1 etc) just transfer Heart Rate.

On the other hand.. libambit driver for Ambit3 might have a role here:
I know for sure I didn't have HR values in Openambit logs for my Ambit3 back then (Feb 2018), just IBI stream; but I found few Moveslink2 SML files from the same watch and those actually include both HR & IBI. Though those Moveslink2 files are newer (Dec 2019) and I had switched from Suunto Smart Sensor belt to Polar H10, not sure if this could make a difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants