-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable handling IBI data as heart rate data in openambit2gpx #211
Conversation
Is there any interest in merging this to master? |
Do you do the IBI->HR conversion because the HR-Data is missing otherwise or do you think the IBI value is "better"? If the former, I would probably try to use "HR" whenever it is available and fall back to IBI only when "HR" is missing to not cause a change compared to all previously generated GPX files. In a quick test it seems generated HR values are slightly different for large parts of the resulting GPX-files, not just some small time-shift. |
I use ibi because the hr data was missing when i tried openambit with my ambit3.
Dominik Stadler <[email protected]> schreef op February 14, 2021 9:31:25 PM UTC:
…Do you do the IBI->HR conversion because the HR-Data is missing
otherwise or do you think the IBI value is "better"?
If the former, I would probably try to use "HR" whenever it is
available and fall back to IBI only when "HR" is missing to not cause a
change compared to all previously generated GPX files.
In a quick test it seems generated HR values are slightly different for
large parts of the resulting GPX-files, not just some small time-shift.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#211 (comment)
|
Ok, so it seems to be depending on the device if the HR samples are available or not. Maybe we can check for the Device in the tag DeviceInfo and choose "HR" or "IBI" based on this to not change produced files for the Devices that properly have HR included already. |
Good suggestion, i will have a look to it next week.
Dominik Stadler <[email protected]> schreef op February 17, 2021 6:28:12 PM UTC:
…Ok, so it seems to be depending on the device if the HR samples are
available or not.
Maybe we can check for the Device in the tag DeviceInfo and choose "HR"
or "IBI" based on this to not change produced files for the Devices
that properly have HR included already.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#211 (comment)
|
@centic9 ,
Not just the watch, it's also depending on used heart rate monitor, at least for Ambit3 - #181 (comment) and following comments, until Mio Link. Suunto Smart ANT belts and Smart Sensor (Bluetooth , for Ambit3 range ) are always sending out IBI values. As far as I know, it's the same for most other ANT+ & Bluetooth chest HRMs as well, at least those by Polar & Garmin. On the other hand.. libambit driver for Ambit3 might have a role here: |
Solves #181: openambit2gpx can now handle IBI data as heart rate data
And has already merge PR #209: python 3 support