This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
allow to disable touch input and one more bug fix #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you describe more detail about bug "when flipping from right to left"? |
|
The bug is that sometimes more than one page is flipped. It occurs basically when you put down your finger on the right edge and move back to the left edge and then keep the finger down in that location for some more time. Sometimes it is not easy to reproduce. Of course it is only left and right if the orientation is set to horizontal. Not sure if the same bug occurs with vertical orientation. |
|
I manually merged your contribution as the automatic merge doesn't work Thanks |
|
@siegfriedpammer 2622d34 is not 100% correct. I've revert it back. Please refer to #46 (comment) for more details |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to be able to disable touch input in some cases, so I just implemented a lock and unlock method. I thought you might find it useful as well...
The other commit is a better solution for the bug I fixed in the last pull request, hope you can include it.
Thanks!