Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py for G6 support #20

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Update setup.py for G6 support #20

merged 1 commit into from
Feb 6, 2019

Conversation

jaylagorio
Copy link
Contributor

Bump the version number so people upgrading using oref0-setup get this when they upgrade openaps to 0.2.2-dev

Discussion here: openaps/openaps#139 (comment)

I believe this has to be updated in Pypi so that Travis doesn't fail the openaps build:

Installed /home/travis/virtualenv/python2.7.14/lib/python2.7/site-packages/openaps-0.2.2.dev0-py2.7.egg
Processing dependencies for openaps==0.2.2.dev0
Searching for dexcom_reader>=0.1.11
Reading https://pypi.python.org/simple/dexcom_reader/
No local packages or working download links found for dexcom_reader>=0.1.11
error: Could not find suitable distribution for Requirement.parse('dexcom_reader>=0.1.11')

Bump the version number so people upgrading using `oref0-setup` get this when they upgrade `openaps` to 0.2.2-dev
@jaylagorio jaylagorio changed the title Update setup.py Update setup.py for G6 support Jan 22, 2019
@scottleibrand scottleibrand merged commit 8b81a3a into openaps:master Feb 6, 2019
@scottleibrand
Copy link
Collaborator

Merged, but looks like only @bewest and @oskarpearson are maintainers of https://pypi.org/project/dexcom_reader/, so one of them will need to release it.

@scottleibrand
Copy link
Collaborator

When I asked him about getting permissions to pypi, Ben replied:

I'd like to ensure everyone who gets maintenance or admin permissions is familiar with the workflow needed to do those things.
I've set up https://github.com/openaps/stdprojectexample as a way to demonstrate those processes on an example project and for pedagogical purposes.
If you could complete the example workflows, I'll add you to pypi maintainers list. I encourage practicing enough to become adept at the process. This is how Oskar received permission.

If anyone (@jaylagorio? @cclauss?) wants to go through those steps, please do. If not, we'll either need to switch over to a CGM comms library that's actively supported (such as @ecc1's dexcom) one and make sure it has full support for all receiver types, or we'll need to switch oref0 over to building dexcom_reader from source instead of installing from pypi.

@cclauss
Copy link
Contributor

cclauss commented Mar 10, 2019

Fixing the syntax errors in #22 should come before any further reliance on dexcom_reader.

@jaylagorio
Copy link
Contributor Author

@scottleibrand @ecc1's dexcom repo seems to be just for G4, so that would need to be updated for both G5 and G6 - which is more work than skipping pypi and building dexcom_reader directly from source. Of course, in guiding the direction of the project if you want to rely more and more on Go in general for device communication that's kind of your perogative.

The two options being cloning and building the Python dexcom_reader during setup or updating the Go dexcom library, which is your preference?

@scottleibrand
Copy link
Collaborator

I'm good with whichever option someone is willing to do, which I suspect means the simplest one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants