Fixes to the install scripts for bullseye & 64bit Raspberry Pi OS installs. #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pip is installed twice - by openaps-install.sh and openaps-packages.sh Handle it (and bullseye issues) in openaps-packages.sh
Check for bullseye If bullseye: - Make python2 the default python - Install pip manually to /usr/local/bin - Use pip to install numpy instead of apt
There is no if/then/elseif condition for aarch64 systems when installing go This means the setup will fail on bullseye 64bit. Add a check for aarch64 & dl/install the correct go version. No impact on 32bit OS installs.
|
Do we also need python3 installed? |
|
Yes.
Python3 and python3-pip are installed during oref0-setup if not already
present (even on buster and earlier).
The issue is that on Buster and earlier, python2 was the 'default python',
with python3 accessed via the python3 executable not the python one.
On bullseye the 'default' is 3 unless you install the python-is-python2
and python-dev-is-python2 meta-packages.
Eventually the distros will drop python2 compltely (or at least the python
project wants them to). But for now the above works.
…On Mon, Feb 28, 2022 at 10:07 AM Jon Cluck ***@***.***> wrote:
Do we also need python3 installed?
—
Reply to this email directly, view it on GitHub
<#1428 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHAS6ZR3Y342A5MA2BUQZ33U5O2WJANCNFSM5PLPIYGQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
It merges the same changes into master that 1429 does into dev.
The reasoning I had for doing it that way is that when following the
documented install process, the install scripts I was fixing always pull
from master to start even if they are going to be used to install dev.
…On Sat, Jun 18, 2022, 7:33 PM Dana Lewis ***@***.***> wrote:
@dcacklam <https://github.com/dcacklam> is this repeat of #1428
<#1428> or something separate?
—
Reply to this email directly, view it on GitHub
<#1428 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHAS6ZXVUNAESHFF3NBSENDVP2BIPANCNFSM5PLPIYGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Ok, thanks for confirming! I merged the other one to dev after we released 0.7.1; we can include this in the next release once someone else tests. Closing this since #1429 achieves the same thing. Thanks again! |
|
It will take slightly different steps to test without 1428, as the install
routine will fail on Bullseye or with 64bit OS before it reaches the code
in 1429....
…On Sat, Jun 18, 2022, 7:43 PM Dana Lewis ***@***.***> wrote:
Ok, thanks for confirming! I merged the other one to dev after we released
0.7.1; we can include this in the next release once someone else tests.
Closing this since #1429 <#1429>
achieves the same thing. Thanks again!
—
Reply to this email directly, view it on GitHub
<#1428 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHAS6ZXL5RCGJUF43UG5PHDVP2CNDANCNFSM5PLPIYGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issues:
openaps-setup trying to install python-pip, which does not exist under bullseye
openaps-packages trying to install python, python-pip, and python-numpy expecting Python2, when Bullseye is python3-based and does not include the python-pip package (just python3-pip).
oref0-setup not having an 'elif' for aarch64/not installing go because of this. Note that armv61l go will not work on an aarch64 OS - you need the arm64 version.
closes #1422