Feature - First MQTT Draft #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DivineThreepwood
approved these changes
Nov 30, 2021
...roller/src/main/java/org/openbase/jul/communication/controller/AbstractControllerServer.java
Outdated
Show resolved
Hide resolved
pLeminoq
commented
Nov 30, 2021
| } | ||
| return getClass().getSimpleName() + "[" + publisher.getScope() + "]"; |
There was a problem hiding this comment.
I think publisher.getScope() now returns our scope proto type whose toString() prints a multi line string. Maybe we this should use the ScopeProcesser.generateStringRep() method.
| this.remoteServerWatchDog.addObserver(middlewareFailureObserver); | ||
| } catch (RuntimeException | InstantiationException ex) { | ||
| throw new CouldNotPerformException("Could not create RemoteServer on scope [" + scope + "]!", ex); | ||
| this.rpcClient = factory.createRPCClient(ScopeProcessor.concat(scope, AbstractControllerServer.SCOPE_SUFFIX_CONTROL), communicatorConfig); |
There was a problem hiding this comment.
We could remove the scope suffix as the MQTT RPC implementation add /rpc to its initialization scope anyway.
| this.subscriberWatchDog.addObserver(middlewareFailureObserver); | ||
| this.rpcClientWatchDog.addObserver(middlewareFailureObserver); | ||
| } catch (RuntimeException ex) { | ||
| throw new CouldNotPerformException("Could not create RPCClient on scope [" + scope + "]!", ex); |
There was a problem hiding this comment.
Scope should be replaced by string rep of ScopeProcessor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
As the title says this PR replaces all RSB classes and interfaces with MQTT.
🔨 Breaking Changes
M requestStatus())