Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix central maven deployment and RCP Communication Improvements. #71

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Fix central maven deployment and RCP Communication Improvements. #71

merged 1 commit into from
Mar 30, 2022

Conversation

DivineThreepwood
Copy link
Member

📜 Description

Changes proposed in this pull request:

Deployment

  • store version into version.txt at root level.
  • close and release artifacts via nexus publish plugin.
  • remove deployment logging

Backend

  • Implement user property support for RPC communication.
  • Auto compute timestamp as user property.
  • Introduce RPCResponce Type that bundles the return value and user properties.
  • Attach timestamp to RPC communication.
  • Fix some typos
  • make sure locks in remote controller communication are using only interruptable locks.

🔨 Breaking Changes

  • rpc publish method requires attach timestamp flag in java.

✅ Checklist:

  • Created tests which fail without the change (if possible)

@DivineThreepwood
Deployment
c67b3ff 
* store version into version.txt at root level.
* close and release artifacts via nexus publish plugin.
* remove deployment logging

Backend
* Implement user property support for RPC communication.
* Auto compute timestamp as user property.
* Introduce RPCResponce Type that bundles the return value and user properties.
* Attach timestamp to RPC communication.
* Fix some typos
* make sure locks in remote controller communication are using only interruptable locks.
@DivineThreepwood DivineThreepwood changed the title Deployment Fix central maven deployment and RCP Communication Improvements. Mar 30, 2022
@DivineThreepwood DivineThreepwood linked an issue Mar 30, 2022 that may be closed by this pull request
Fix Central Maven Deployment #70
Closed
@DivineThreepwood DivineThreepwood merged commit 9e57d12 into dev Mar 30, 2022
@DivineThreepwood DivineThreepwood deleted the feature/#70_fix_central_maven_deployment branch March 30, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pLeminoq pLeminoq Awaiting requested review from pLeminoq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Central Maven Deployment
1 participant
@DivineThreepwood