-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#81 avoid empty label entries #82
Feature/#81 avoid empty label entries #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
detekt found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just 2 minor suggestions you can have a look at.
|
||
@JvmField | ||
val UNKNOWN_LABEL = addLabel(LabelType.Label.newBuilder(), Locale.ENGLISH, "?").build() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe use generateLabelBuilder or buildLabel instead of addLabel
fun formatLabel() { | ||
println("formatLabel") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe rename to something more specific such as test format removes language with empty labels
π Description
Changes proposed in this pull request:
β Checklist: