Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/bco#77 review protobuf merge from usage to avoid list entry dublication #83

Conversation

DivineThreepwood
Copy link
Member

@DivineThreepwood DivineThreepwood commented Oct 27, 2022

📜 Description

Changes proposed in this pull request:

  • Introduce mergeFromWithoutRepeatedFields extension function of Message.Builder
  • Introduce clearRepeatedFields extension function of Message.Builder
  • Implement Test for mergeFromWithoutRepeatedFields
  • Implement Test for clearRepeatedFields

✅ Checklist:

  • Created tests which fail without the change.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detekt found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@pLeminoq pLeminoq merged commit 7bed107 into feature/tests Nov 3, 2022
@pLeminoq pLeminoq deleted the bugfix/bco#77_review_protobuf_merge_from_usage_to_avoid_list_entry_dublication branch November 3, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants