templated service files are broken

[williamspatrick]

The repository has a number of templated services files, such as:

$ cat ./monitor/service_files/json/[email protected]
[Unit]
Description=Phosphor Fan Monitor Daemon
After=mapper-wait@-xyz-openbmc_project-inventory.service

[Service]
Restart=on-failure
ExecStart=/usr/bin/phosphor-fan-monitor  <------ ??

There is nothing in this template file that is templated. There is no use of the %I field, for example.

In meta-phosphor, these templates are being installed based on OBMC_CHASSIS_INSTANCES:

SYSTEMD_LINK:${PN}-monitor += "${@bb.utils.contains('PACKAGECONFIG', 'json', \
                                compose_list(d, 'FMT_MONITOR_MUSR', 'OBMC_CHASSIS_INSTANCES'), \
                                compose_list(d, 'FMT_MONITOR_INIT', 'OBMC_CHASSIS_INSTANCES'), d)}"

The side-effect of this is any multi-chassis system ends up with N instances of this template installed, each of which tries to launch the same phosphor-fan-monitor program, of which N-1 crash due to the dbus server name already being taken. Unfortunately, the service files are also written with Restart=on-failure, so we end up with a continuous loop of crash/restart/crash/restart on N-1 instances of the service, which fills up the phosphor-debug-collector almost instantly and consumes plenty of CPU.

[spinler]

Yea, that's definitely a problem that a templated service wouldn't also claim a templated D-Bus name.

[msbarth]

FWIW, it was templated for the yaml version of the service files. The json versions no longer required the use of %i
https://github.com/openbmc/phosphor-fan-presence/blob/master/monitor/service_files/yaml/phosphor-fan-monitor%40.service

[williamspatrick]

Shouldn't have been closed. I wrote "partially resolves"...