Cadc 12356 Add support for desktop-app to Skaha API #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eturn desktop-app ID.
brianmajor
requested changes
May 3, 2023
… based on Brian's review comments.
…esktop-app. This change has not been tested on keel-dev yet. Currently keel-dev is down.
…inst allowed optional values.
… when there is an error launching a desktop-app.
… by start-software-template.
…s assumes that CADC-12493 will be released first.
…sing config parameters in catalina.properties.
…on of xterm to skaha-desktop Docker file.
at88mph
requested changes
Jun 13, 2023
deployment/k8s-config/kustomize/base/skaha-workload/config/templates/start-software-sh.template
Outdated
Show resolved
Hide resolved
deployment/k8s-config/kustomize/base/skaha/skaha-tomcat-deployment.yaml
Outdated
Show resolved
Hide resolved
deployment/k8s-config/kustomize/overlays/keel-dev/skaha/skaha-tomcat-deployment.yaml
Outdated
Show resolved
Hide resolved
|
I would also like to add support for this in the Python Skaha API. Documentation on usage would be great when the PR is merged. |
…to use gnome-terminal instread of xterm to avoid an xterm being launched on skaha-desktop startup. Now there is a added menu item (Applications->System->Terminal) that needs to be removed.
…and Applications-<Other.
brianmajor
requested changes
Jun 26, 2023
deployment/k8s-config/kustomize/base/skaha-workload/config/k8s-resources.properties
Outdated
Show resolved
Hide resolved
deployment/k8s-config/kustomize/base/skaha-workload/config/templates/start-software-sh.template
Outdated
Show resolved
Hide resolved
deployment/k8s-config/kustomize/base/skaha-workload/kustomization.yaml
Outdated
Show resolved
Hide resolved
deployment/k8s-config/kustomize/base/skaha/config/catalina.properties
Outdated
Show resolved
Hide resolved
…-resources.properties.
…op Dockerfile. jq needs to be installed after epel-release has been installed.
…ovide error info.
brianmajor
requested changes
Jul 12, 2023
deployment/k8s-config/kustomize/base/skaha/config/launch-carta.yaml
Outdated
Show resolved
Hide resolved
…rs until a status is returned. Also check status while status is 'Pending'.
…uccessful message.
brianmajor
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desktop-app creation will allow user to specify number of cores and amount of RAM.
New Skaha API to be added:
GET /session/{sessionID}/app. -- returns a list of desktop-app
GET /session/{sessionID}/app/{appID}. -- returns the specified desktop-app
DELETE /session/{sessionID}/app/{appID} -- deletes the specified desktop-app