CADC-13452 ingest an existing table into the tap_schema #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-action classes
… ingesting a table
…le index tests from CreateTableTest
# Conflicts: # cadc-tap-schema/src/main/java/ca/nrc/cadc/vosi/actions/PutAction.java
pdowler
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Some preliminary comments on the TableIngester and datatype handling only.
An alternative to the comment I made about the TableIngester ctor: maybe ingest should just return the TableDesc and the calling code should do the TapSchemaDAO transaction?? Then that code could be used in ways other, like validating tap_schema vs table. Thoughts?
cadc-tap-server-pg/src/main/java/ca/nrc/cadc/tap/pg/PostgresDataTypeMapper.java
Show resolved
Hide resolved
cadc-tap-schema/src/main/java/ca/nrc/cadc/tap/db/BasicDataTypeMapper.java
Show resolved
Hide resolved
pdowler
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.