Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Web Token library. #46

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Added Web Token library. #46

merged 1 commit into from
Dec 21, 2023

Conversation

at88mph
Copy link
Member

@at88mph at88mph commented Dec 7, 2023

No description provided.

Copy link
Member

@brianmajor brianmajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is assumed the redis server is running somewhere already? I didn't see a 'lookup' step or anything from the Jedis code.

Operationally, having redis available is probably much easier in k8s. I guess we should talk about this will the ops group and see what they think.


private final String accessToken;
private final String refreshToken;
private final long expiryTimeMilliseconds;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the subject and issuer (sub & iss) would be useful to have here for debugging or logging purposes.

@at88mph
Copy link
Member Author

at88mph commented Dec 11, 2023

This library will assume a Cache is running. We supply a client for Redis using the jedis library. One would pass the URL to the Redis server, or their own implementation of the TokenStore, such a Map<String, String> if they so choose.
https://github.com/opencadc/web/pull/46/files#diff-02e083d74810595ac4d604e6d6a85325285946e46bb9512f163e6dd9da8e4366

@brianmajor
Copy link
Member

Ah, I see, thanks.

@at88mph at88mph merged commit af59498 into master Dec 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants