Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK-5979 - Automatize validation of SSO with CAS for OpenCGA Enterprise 2.x.x #2461

Merged
merged 13 commits into from
Jul 1, 2024

Conversation

pfurio
Copy link
Member

@pfurio pfurio commented Jun 7, 2024

No description provided.

@pfurio pfurio requested a review from j-coll June 7, 2024 08:44
@Parameter(names = {"--optimizations-simplify-permissions"}, description = "The body web service simplifyPermissions parameter", required = false, help = true, arity = 0)
public boolean optimizationsSimplifyPermissions = false;

@Parameter(names = {"--token-algorithm"}, description = "The body web service algorithm parameter", required = false, arity = 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing param descriptions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's automatically generated. I know we need to change those description values :S

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I meant was that you should add these descriptions with "@Datafield" in the "Organization configuration"

j-coll
j-coll previously approved these changes Jun 7, 2024
j-coll
j-coll previously approved these changes Jun 20, 2024
@j-coll j-coll changed the title TASK-5979: Automatize validation of SSO with CAS for OpenCGA Enterprise 2.x.x TASK-5979 - Automatize validation of SSO with CAS for OpenCGA Enterprise 2.x.x Jun 28, 2024
@pfurio pfurio merged commit de0568c into develop Jul 1, 2024
9 of 12 checks passed
@pfurio pfurio deleted the TASK-5979 branch July 1, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants